Fixed a bug in package/package_settings (super called without explicit parameters)#2280
Closed
ptomulik wants to merge 2 commits intopuppetlabs:masterfrom
Closed
Fixed a bug in package/package_settings (super called without explicit parameters)#2280ptomulik wants to merge 2 commits intopuppetlabs:masterfrom
ptomulik wants to merge 2 commits intopuppetlabs:masterfrom
Conversation
|
CLA signed by all contributors. |
Some ruby versions raised the following exceptions when validating the package_settings: implicit argument passing of super from method defined by define_method() is not supported. Specify all arguments explicitly. This commit fixes the bug.
|
Replaced by #2285. |
Contributor
Author
|
Ok, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some ruby versions were raising the following exceptions during validation of the package_settings:
implicit argument passing of super from method defined by define_method() is not supported. Specify all arguments explicitly.This PR adds appropriate specs to (dis)cover the bug and fixes it.