Skip to content

Clarified pattern parameter for Service type (DOCUMENT-1)#2294

Merged
adrienthebo merged 2 commits intopuppetlabs:masterfrom
juxtin:servicedocs
Mar 13, 2014
Merged

Clarified pattern parameter for Service type (DOCUMENT-1)#2294
adrienthebo merged 2 commits intopuppetlabs:masterfrom
juxtin:servicedocs

Conversation

@juxtin
Copy link
Contributor

@juxtin juxtin commented Jan 24, 2014

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you elaborate on why this is the case?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this doing

service { 'foo':
  pattern => 'some-regex',
}

As opposed to

service { 'foo':
  pattern => '/some-regex/',
}

?

@juxtin
Copy link
Contributor Author

juxtin commented Jan 31, 2014

Thanks, @adrienthebo, that's exactly what I meant. I've updated it again to make that clearer.

@adrienthebo
Copy link
Contributor

@holguinj I'm not sure if you were at the meeting where we were discussing different projects in JIRA but there are some kinda strange implications for having commits in Puppet that are not in the PUP project. For instance indicating the release version of this fix is strange to represent in JIRA. For my understanding could you explain why this is in the DOCUMENT project instead of PUP?

@juxtin
Copy link
Contributor Author

juxtin commented Jan 31, 2014

I think it ended up in DOCUMENT because it was spotted at Docs: Type Reference. If that messes with the platform workflow then we're happy to figure out a better way to handle issues like this.

adrienthebo added a commit that referenced this pull request Mar 13, 2014
Clarified `pattern` parameter for Service type (DOCUMENT-1)
@adrienthebo adrienthebo merged commit 5a68345 into puppetlabs:master Mar 13, 2014
@adrienthebo
Copy link
Contributor

Merged into master in 5a68345; this should be released in 3.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants