Clarified pattern parameter for Service type (DOCUMENT-1)#2294
Clarified pattern parameter for Service type (DOCUMENT-1)#2294adrienthebo merged 2 commits intopuppetlabs:masterfrom
pattern parameter for Service type (DOCUMENT-1)#2294Conversation
lib/puppet/type/service.rb
Outdated
There was a problem hiding this comment.
Could you elaborate on why this is the case?
There was a problem hiding this comment.
Is this doing
service { 'foo':
pattern => 'some-regex',
}As opposed to
service { 'foo':
pattern => '/some-regex/',
}?
|
Thanks, @adrienthebo, that's exactly what I meant. I've updated it again to make that clearer. |
|
@holguinj I'm not sure if you were at the meeting where we were discussing different projects in JIRA but there are some kinda strange implications for having commits in Puppet that are not in the PUP project. For instance indicating the release version of this fix is strange to represent in JIRA. For my understanding could you explain why this is in the DOCUMENT project instead of PUP? |
|
I think it ended up in DOCUMENT because it was spotted at Docs: Type Reference. If that messes with the platform workflow then we're happy to figure out a better way to handle issues like this. |
Clarified `pattern` parameter for Service type (DOCUMENT-1)
|
Merged into master in 5a68345; this should be released in 3.6.0. |
No description provided.