(pup-640) Update report schema for error events#2307
Merged
zaphod42 merged 1 commit intopuppetlabs:masterfrom Feb 1, 2014
Merged
Conversation
Previously, special handling was added to synthesize a report event even when the property application failed early. However, when this change was made the report schema wasn't updated, so the schema did not allow for several fields in the event to be null (as they are for one of these synthesized events). This change updates the report schema to reflect that certain fields can be null. It also adds a spec test including an error event, which requires the schema change in order to pass.
|
CLA signed by all contributors. |
Author
|
See puppetlabs/puppet-docs#275 for the complementary puppet-docs change. |
zaphod42
added a commit
that referenced
this pull request
Feb 1, 2014
…es-for-error-events (pup-640) Update report schema for error events
kylog
deleted the
issue/pup-640/report-schema-updates-for-error-events
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, special handling was added to synthesize a report
event even when the property application failed early. However,
when this change was made the report schema wasn't updated,
so the schema did not allow for several fields in the event
to be null (as they are for one of these synthesized events).
This change updates the report schema to reflect that certain
fields can be null. It also adds a spec test including an error
event, which requires the schema change in order to pass.