Maint/master/acceptance harness releases pooled hosts#2339
Merged
jpartlow merged 3 commits intopuppetlabs:masterfrom Mar 6, 2014
Merged
Conversation
|
CLA signed by all contributors. |
Contributor
Author
|
Fixed! Thanks for catching that @kylog |
|
Actually @jpartlow after I commented here, I realized that the missing I should have mentioned this when I found it but it slipped my mind. Other than that I'm (thumbsup) on this change. |
Contributor
Author
|
Ah, right; I will rebase. |
Contributor
Author
|
I'll hold off on merging until after we get acceptance sorted out for the ruby-shadow issue. |
Our configurations now uses Scott's vcloud pooling api, so rather than attempt to destroy them directly through vsphere (the code for which was no longer working with current rbvmomi anyway) we are submitting them to the pooling api for deletion.
Package re-installation and rsyncing of local code changes while re-running acceptance tests on preserved vms is something we aren't doing. A better solution for the cycle of acceptance testing against local changes is to use a git install against a local git daemon (see the docs/acceptance_tests.md) to test against changes you have checked in locally.
Beaker can now be set to preserve hosts if the acceptance run fails. We are now defaulting to that for ci and manual testing, and pinning to Beaker ~>1.7.0, so any release on the 1.7 line.
jpartlow
added a commit
that referenced
this pull request
Mar 6, 2014
…s-releases-pooled-hosts Maint/master/acceptance harness releases pooled hosts
jpartlow
deleted the
maint/master/acceptance-harness-releases-pooled-hosts
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates to Beaker 1.6.2, which allows us to preserve hosts on fail. This is now the default. Also updates the cleanup code to check preserved hosts back into the pooling api, and clears out unused rsync code for preserved hosts.