(PUP-1592) Speed up loading of user defined types by 2x#2373
Merged
hlindberg merged 1 commit intopuppetlabs:masterfrom Feb 21, 2014
Merged
(PUP-1592) Speed up loading of user defined types by 2x#2373hlindberg merged 1 commit intopuppetlabs:masterfrom
hlindberg merged 1 commit intopuppetlabs:masterfrom
Conversation
When a user defined type is loaded a check is always first made to see if the name loads a resource type implemented in ruby. The majority of loads are for non ruby types. The loading must be done with higher precedence of ruby based resource type over user defined. This optimization capitalizes on the fact that ruby resource types are in a flat name space and thus their names can never contain '::'. The optimization is done in metatype/manager.rb where now an attempt to load from the type loader is avoided if the name contains a ':'. This achieves a 2x speedup and generates less permanent garbage (all user defined type names where internalized as symbols, never to be gc'd).
|
CLA signed by all contributors. |
hlindberg
added a commit
that referenced
this pull request
Feb 21, 2014
(PUP-1592) Speed up loading of user defined types by 2x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user defined type is loaded a check is always first made
to see if the name loads a resource type implemented in ruby. The
majority of loads are for non ruby types. The loading must be done with
higher precedence of ruby based resource type over user defined.
This optimization capitalizes on the fact that ruby resource types are
in a flat name space and thus their names can never contain '::'. The
optimization is done in metatype/manager.rb where now an attempt to load
from the type loader is avoided if the name contains a ':'.
This achieves a 2x speedup and generates less permanent garbage (all
user defined type names where internalized as symbols, never to be
gc'd).