(#7110) Better SSL error message when certificate doesn't match key#249
Merged
jeffmccune merged 1 commit intopuppetlabs:masterfrom Dec 8, 2011
lifton:master
Merged
(#7110) Better SSL error message when certificate doesn't match key#249jeffmccune merged 1 commit intopuppetlabs:masterfrom lifton:master
jeffmccune merged 1 commit intopuppetlabs:masterfrom
lifton:master
Conversation
spec/unit/ssl/host_spec.rb
Outdated
Contributor
Author
There was a problem hiding this comment.
Something is wrong here. Seems like this test shouldn't be passing because it has the wrong error message. I'll look into this.
Contributor
Author
There was a problem hiding this comment.
Fixed. A bad error message was camouflaged by a bad test.
Previously, any error with the certificate retrieved from the master matching the agent's private key would give the same static error message, which wasn't particularly helpful. This commit differentiates three different error cases: missing certificate, missing private key, and certificate doesn't match private key. In the last case, the error message includes the fingerprint of the certificate in question and explicit command line instructions on how to fix the problem. In addition to all tests passing, I tested the error messaging and included instructions in a virtual machine setup running PE 2.0.0.
jeffmccune
pushed a commit
that referenced
this pull request
Dec 8, 2011
(#7110) Better SSL error message when certificate doesn't match key
hlindberg
pushed a commit
to hlindberg/puppet
that referenced
this pull request
Oct 16, 2014
Fix incorrect puppet path and add puppet apply --graph
melissa
pushed a commit
to melissa/puppet
that referenced
this pull request
Mar 30, 2018
(maint) Update upstream CI cpp-pcp-client 1.0.2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, any error with the certificate retrieved from the master
matching the agent's private key would give the same static error
message, which wasn't particularly helpful. This commit differentiates
three different error cases: missing certificate, missing private key,
and certificate doesn't match private key. In the last case, the error
message includes the fingerprint of the certificate in question and
explicit command line instructions on how to fix the problem.
In addition to all tests passing, I tested the error messaging and
included instructions in a virtual machine setup running PE 2.0.0.
I removed a redundant test.
Thanks to Jeff McCune, Jacob Helwig, and Nick Lewis for answering questions and giving suggestions.