Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature/master/pup 1840 tunable digest algorithm #2537
referenced this pull request
Apr 15, 2014
These changes look complete to me. This pull request is indeed a better replacement for GH-2452.
Do you think the setting should be called file_checksum_algorithm rather than digest_algorithm, to avoid terminology conflicts with the SSL parts of Puppet?
I think that right now the only major use of the digest algorithm is in file checksumming, but I don't think it's limited to that. Given https://github.com/puppetlabs/puppet/pull/2453/files it's reasonable to see other components will need to use a digest algorithm so I think it's good to keep it generic.
Good point; I agree. Now I think the only thing in the way is the migration concerns (http://projects.puppetlabs.com/issues/8120#note-10).