(PUP-2454) User ID's below 1000, not 500, are generally considered system users on OpenBSD#2547
(PUP-2454) User ID's below 1000, not 500, are generally considered system users on OpenBSD#2547jasperla wants to merge 1 commit intopuppetlabs:masterfrom jasperla:unless_system_user
Conversation
|
CLA signed by all contributors. |
jasperla
changed the title
|
I'd like to see this change prefaced with a refactor so that this magic number is segregated into its own method. The change itself will then only affect that method. As was mentioned during the PR, this change would also make sense for the 'Debian' value of operatingsystem. To that end, I'd prefer to see this done with a |
lib/puppet/type/resources.rb
Outdated
There was a problem hiding this comment.
It looks like Debian system UIDs span from 100 to 999:
# /etc/login.defs
# System accounts
#SYS_UID_MIN>...>....... 100
#SYS_UID_MAX>...>....... 999
There was a problem hiding this comment.
There was a problem hiding this comment.
Right, so we could consider accounts <= 999 to be system accounts (thereby ignoring 0 < x <= 99)? Come to think of it, for OpenBSD it should be 999 too since UID 1000 would be the first regular user account.
Shall I merge the OpenBSD and Debian case into a single case returning '999'?
There was a problem hiding this comment.
On 05/21/2014 08:14 PM, Jasper Lievisse Adriaanse wrote:
Shall I merge the OpenBSD and Debian case into a single case returning
'999'?
Fine by me.
…on OpenBSD. Users can still modify this with 'uid_start' in adduser.conf, but in that case they'd need to provide an actual value instead of 'true'. While here, include Debian to the list of systems with system user UIDs < 1000
|
Argh dammit I just realized - this likely also applies to Ubuntu. Perhaps it would be safer to rely on |
|
Yeah, I think using @jasperla Can you push up that fix and possibly a spec example that tests |
|
Sorry for not following up on this before, and thanks for taking care of it. |
6 participants
Users can still modify this with 'uid_start' in adduser.conf, but in that
case they'd need to provide an actual value instead of 'true'.