(PUP-1100) Fix error message with create_resource and auto-loaded class#2761
Merged
adrienthebo merged 2 commits intopuppetlabs:masterfrom Jun 26, 2014
Merged
(PUP-1100) Fix error message with create_resource and auto-loaded class#2761adrienthebo merged 2 commits intopuppetlabs:masterfrom
adrienthebo merged 2 commits intopuppetlabs:masterfrom
Conversation
|
CLA signed by all contributors. |
Contributor
There was a problem hiding this comment.
Looks good overallt. The content of the expect { } block should be indented one level. There heredoc is gratuitous, seeing as it's a one line manifest, that should just be a 'string'.
Contributor
Author
There was a problem hiding this comment.
Done, rebased & force-pushed.
added 2 commits
June 12, 2014 15:18
This commit adds a check for the create_resources syntax error message. If there is a syntax error, the error given by puppet master is unclear. This commits adds a test to check that the error message is correct and makes sense. This only happens when the resources are auto imported, which is why I use a fixture directory.
This commit fixes the error message displayed by PM when a syntax error is present on an file auto-loaded by create_resources.
adrienthebo
added a commit
that referenced
this pull request
Jun 26, 2014
(PUP-1100) Fix error message with create_resource and auto-loaded class
Contributor
|
Merged into master in c664ad0, this should be released in 3.7.0. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These commits fix the error message displayed by PM when a syntax error
is present on an auto-loaded file.