(PUP-2918) Remove reduntant acceptance test for new build output#2888
Merged
kylog merged 1 commit intopuppetlabs:masterfrom Jul 18, 2014
Conversation
andersonmills
changed the title
andersonmills
changed the title
Before this commit, the acceptance tests fail because the output of the puppet module build action has changed for missing Modulefile and metadata.json files. With this commit, the acceptance test is removed, because this behavior is covered in the spec tests.
|
Waiting for CLA signature by @andersonmills @andersonmills - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppetlabs.com/ Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppetlabs.com/community/trivial_patch_exemption.html |
kylog
pushed a commit
that referenced
this pull request
Jul 18, 2014
…ance_tests_for_build_messages (PUP-2918) Remove redundant acceptance test for new build output
|
I went ahead and merged despite the travis failures, which are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this commit, the acceptance tests fail because the output of the
puppet module build action has changed for missing Modulefile and
metadata.json files. With this commit, the acceptance test is removed,
because this behavior is covered in the spec tests.