Skip to content

(PUP-778) Add yumrepo acceptance smoke test#3035

Closed
johnduarte wants to merge 1 commit intopuppetlabs:masterfrom
johnduarte:pup-778-yumrepo-smoke
Closed

(PUP-778) Add yumrepo acceptance smoke test#3035
johnduarte wants to merge 1 commit intopuppetlabs:masterfrom
johnduarte:pup-778-yumrepo-smoke

Conversation

@johnduarte
Copy link
Contributor

This commit adds an acceptance test for the yumrepo resource. It
verified that yumrepos can be ensured both present and absent and
that they are then visible as yumrepo resources.

@puppetcla
Copy link

CLA signed by all contributors.

This commit adds an acceptance test for the yumrepo resource. It
verified that yumrepos can be ensured both present and absent and
that they are then visible as yumrepo resources.
@hlindberg
Copy link
Contributor

Triage Notes:

  • Can this be an integration test instead? (acceptance tests should only be used if it is impossible to test with an integration or unit level test)
  • @joshcooper the yumrepo type has a target parameter, you can run a puppet apply and add the target parameter and assert that the right files are created - say comparing to a fixture.
  • ping @johnduarte

@peterhuene
Copy link
Contributor

PR triage notes: waiting on @johnduarte for feedback. Is this a test coverage hole currently in specs?

@kylog kylog added the Unix label Jan 5, 2015
@joshcooper
Copy link
Contributor

PR Triage Notes:

  • @johnduarte @er0ck wondering if you've had a chance to review this PR and see what can be implemented as integration tests?

@er0ck er0ck closed this Jan 21, 2015
@er0ck
Copy link
Contributor

er0ck commented Jan 21, 2015

closed in favor of future work in PUP-3886

@johnduarte johnduarte deleted the pup-778-yumrepo-smoke branch February 11, 2015 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants