(PUP-3505) Fix problem with passing explicit undef res parameter#3229
Merged
zaphod42 merged 1 commit intopuppetlabs:stablefrom Oct 24, 2014
Merged
Conversation
With the future parser in effect and a resource attribute is undef the logic that checks for missing arguments did not report the parameter. This in turn led to that the logic that either fails the operation, or assigns the default value to completely skip that parameter/argument. Subsequently a reference of that parameter ended up picking the same variable from an outer context. The fix is to equate a nil value (4x) with an :undef value (for 3x) when computing the missing arguments. A test is added that tests the functionality.
|
CLA signed by all contributors. |
zaphod42
added a commit
that referenced
this pull request
Oct 24, 2014
…idered-missing (PUP-3505) Fix problem with passing explicit undef res parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the future parser in effect and a resource attribute is undef the
logic that checks for missing arguments did not report the parameter.
This in turn led to that the logic that either fails the operation, or
assigns the default value to completely skip that parameter/argument.
Subsequently a reference of that parameter ended up picking the same
variable from an outer context.
The fix is to equate a nil value (4x) with an :undef value (for 3x) when
computing the missing arguments.
A test is added that tests the functionality.