#12070 Fix crontab value munging#361
Merged
slippycheeze merged 5 commits intopuppetlabs:2.7.xfrom Jan 21, 2012
Merged
Conversation
rspec already gives us a described_class method so why not using it.
Instead of using a mock object it is simpler to just create a real provider class. We now also have a @provider_class.new method and there is no need for a fake provider instance.
Two tests will now fail because the error message does not match the expected behaviour. 1) Puppet::Type::Cron when validating attribute weekday should not support invalid steps 2) Puppet::Type::Cron when validating attribute month should not support invalid steps
If the specified value does include characters that have a special
meaning inside a regex puppet raised errors like
target of repeat operator is not specified: /*\/a/i
Change if clause to do a real substring tests instead of using a regex.
All spec tests do now pass
Contributor
|
Reviewed, +1. |
slippycheeze
added a commit
that referenced
this pull request
Jan 21, 2012
#12070 Fix crontab value munging
hlindberg
pushed a commit
to hlindberg/puppet
that referenced
this pull request
Oct 16, 2014
Remove two guides and change all relevant links
melissa
pushed a commit
to melissa/puppet
that referenced
this pull request
Mar 30, 2018
(maint) Update modules' interface doc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit series starts as a few refactoring steps for the cron type spec where I discovered the error. The last commit finally fixes #12070