Ticket/2.7.x/5362

[nanliu]

This doesn't resolve the underlying issue, but it sets path=false if the
user provide a server setting for filebucket, so users no longer need
to use this work around:

filebucket { 'remote':
  server => 'puppet',
  path => false, #no longer required.
}

The documentation on the type have been updated, but there are other
places where this should also be updated.

[slippycheeze]

Hey. That change looks wrong to me, for production code.

[nanliu]

Should I keep it as server => puppet? I was just showing an example and false is not necessary.

[slippycheeze]

That seems like a better default, especially given we use that as our default server name. :)

[slippycheeze]

I would generally prefer to get to the underlying problem, not work around it like this. Did you identify that fixing the core of the issue was a substantially bigger, or more risky, effort than this targetted change?

[nanliu]

Fixing the underlying problem requires checking the file resource type behavior which is beyond what I intended for a quick hack-a-thon pull request.

[slippycheeze]

Sure. I can appreciate that, but I am not going to accept the change because of it without that background checking. Do you think you can do that? If not, I am going to have to reject the change, which I really don't want to do. I just want to make sure we are not rearranging deck chairs while the iceberg looms...