I added a syntax highlighting file for the kate editor#38
I added a syntax highlighting file for the kate editor#38dingus9 wants to merge 2 commits intopuppetlabs:masterfrom dingus9:master
Conversation
|
File added in /ext/kate/puppet.xml |
|
Thanks for submitting this, however I don't think that we should merge this in at this point, since there is a desire to separate out the existing vim & emacs syntax highlighting files into their own repositories (related Redmine issue). Also, we need a CLA from anyone that we accept contributions from (CONTRIBUTING.md), and generally have all of our released code as Apache licensed. Before creating a repo for this under the puppetlabs account, I'd like to have some discussion from people who are more familiar with the licensing issues. Would you mind opening a ticket in Redmine about possibly creating a new repo for the Kate syntax highlighting? |
|
Jacob - it doesn't need to be Apache-licensed unless it ships with Puppet - just an open source license is fine if it's a standalone repo. |
|
ill do what ever you guys think is best... personally it would probably be a good idea to have a separate repo for third party tools. I would think it would make ot easier to include provisioning or other tools that dont quite fit into puppet itself. |
(PUP-2683) Fix fact terminus to load facts without '.' on the load path.
Remove lingering reference to license app in debian packaging
Fix #11411 - Added section on variable formatting
The file is licensed LGPL and based on the ruby syntax file shipped with kubuntu, and I believe most kate packages.