Skip to content

I added a syntax highlighting file for the kate editor#38

Closed
dingus9 wants to merge 2 commits intopuppetlabs:masterfrom
dingus9:master
Closed

I added a syntax highlighting file for the kate editor#38
dingus9 wants to merge 2 commits intopuppetlabs:masterfrom
dingus9:master

Conversation

@dingus9
Copy link
Copy Markdown

@dingus9 dingus9 commented Aug 15, 2011

The file is licensed LGPL and based on the ruby syntax file shipped with kubuntu, and I believe most kate packages.

@dingus9
Copy link
Copy Markdown
Author

dingus9 commented Aug 15, 2011

File added in /ext/kate/puppet.xml

@dingus9 dingus9 closed this Aug 15, 2011
@dingus9 dingus9 reopened this Aug 15, 2011
@jhelwig
Copy link
Copy Markdown
Contributor

jhelwig commented Nov 18, 2011

Thanks for submitting this, however I don't think that we should merge this in at this point, since there is a desire to separate out the existing vim & emacs syntax highlighting files into their own repositories (related Redmine issue).

Also, we need a CLA from anyone that we accept contributions from (CONTRIBUTING.md), and generally have all of our released code as Apache licensed. Before creating a repo for this under the puppetlabs account, I'd like to have some discussion from people who are more familiar with the licensing issues. Would you mind opening a ticket in Redmine about possibly creating a new repo for the Kate syntax highlighting?

@jhelwig jhelwig closed this Nov 18, 2011
@jamtur01
Copy link
Copy Markdown
Contributor

Jacob - it doesn't need to be Apache-licensed unless it ships with Puppet - just an open source license is fine if it's a standalone repo.

@dingus9
Copy link
Copy Markdown
Author

dingus9 commented Nov 21, 2011

ill do what ever you guys think is best... personally it would probably be a good idea to have a separate repo for third party tools. I would think it would make ot easier to include provisioning or other tools that dont quite fit into puppet itself.

joshcooper added a commit that referenced this pull request Jun 10, 2014
(PUP-2683) Fix fact terminus to load facts without '.' on the load path.
Iristyle pushed a commit to Iristyle/puppet that referenced this pull request Sep 9, 2014
Remove lingering reference to license app in debian packaging
hlindberg pushed a commit to hlindberg/puppet that referenced this pull request Oct 16, 2014
Fix #11411 - Added section on variable formatting
melissa pushed a commit to melissa/puppet that referenced this pull request Mar 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants