Bug/2.7.x/6710 fixed 1.9.2 test failures#383
Merged
grimradical merged 1 commit intopuppetlabs:2.7.xfrom Jan 21, 2012
slippycheeze:bug/2.7.x/6710-fixed-1.9.2-test-failures
Merged
Bug/2.7.x/6710 fixed 1.9.2 test failures#383grimradical merged 1 commit intopuppetlabs:2.7.xfrom slippycheeze:bug/2.7.x/6710-fixed-1.9.2-test-failures
grimradical merged 1 commit intopuppetlabs:2.7.xfrom
slippycheeze:bug/2.7.x/6710-fixed-1.9.2-test-failures
Conversation
The behaviour of Array#to_s is different between 1.8.7 and 1.9.2, and this code actually depended on the older behaviour. Since this is part of a stable series, the smallest set of changes possible to make things work have been applied - and a ticket filed to do the deep analysis of data flow required to fix this properly in a release where we have more stomach for risk. Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>
grimradical
added a commit
that referenced
this pull request
Jan 21, 2012
…2-test-failures Bug/2.7.x/6710 fixed 1.9.2 test failures
hlindberg
pushed a commit
to hlindberg/puppet
that referenced
this pull request
Oct 16, 2014
tdevelioglu
pushed a commit
to tdevelioglu/puppet
that referenced
this pull request
Mar 29, 2016
melissa
pushed a commit
to melissa/puppet
that referenced
this pull request
Mar 30, 2018
(PCP-329) Update ruby-pcp-client to pick up EventMachine improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The behaviour of Array#to_s is different between 1.8.7 and 1.9.2, and this
code actually depended on the older behaviour.
Since this is part of a stable series, the smallest set of changes possible to
make things work have been applied - and a ticket filed to do the deep
analysis of data flow required to fix this properly in a release where we have
more stomach for risk.
Signed-off-by: Daniel Pittman daniel@puppetlabs.com