Schedule/bug/10296 test cleanup 2.7.x#389
Merged
stschulte merged 1 commit intopuppetlabs:2.7.xfrom Jan 23, 2012
Merged
Conversation
Per Patrick's explanation in #10296, all of the "should" forms of the rspec tests have been converted to "must" forms to that the tests will function properly. As part of this cleanup, one test was found that was "should" and converted to "must_not" as the original logic seemed inconsistent with the test.
melissa
pushed a commit
to melissa/puppet
that referenced
this pull request
Mar 30, 2018
(PCP-374) Update Catch configuration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per Patrick's explanation in #10296, all of the
"should" forms of the rspec tests have been converted
to "must" forms to that the tests will function properly.
As part of this cleanup, one test was found that was "should"
and converted to "must_not" as the original logic seemed
inconsistent with the test.
This has been rebased against 2.7.x per Stefan's request in pull request #385. It didn't seem like I could modify the pull request in #385 adequately so I'm putting in this new one.