(maint) remove extra gems from appveyor

[Iristyle]

• When running specs in our local Jenkins environment, the
  'extra' gems, which include 'msgpack' are not installed. We do
  this because:

  • 'msgpack' requires building native code, which unnecessarily
    adds to the feedback loop
  • we intentionally try to maintain a clean environment without
    the Ruby DevKit installed

  This has previously worked on AppVeyor because they have the
  Ruby DevKit installed.

[ferventcoder]

makes sense. Curious if puppetlabs_spec_helper is necessary though?

[joshcooper]

For reference, list of appveyor preinstalled software

[ferventcoder]

Waiting for Travis/AppVeyor...

[joshcooper]

Pretty sure puppetlabs_spec_helper is not required. It was added in 0350afd, but it introduces a cyclic dependency as puppetlabs_spec_helper depends on puppet. Also tzinfo is not used in puppet from what I can tell:

$ git grep -i tzinfo
Gemfile:  gem "tzinfo", :require => false

That said cleaning up the Gemfile can be a separate PR

[ferventcoder]

👍

[MikaelSmith]

Looks no worse than before.

[ferventcoder]

The fun rdoc issue that just won't go away. Possibly made worse now. Perhaps we ensure those don't run as part of this fix?

[ferventcoder]

I rekicked the PR

[joshcooper]

The rdoc issue is PUP-4537, I've updated with my notes recently...

[puppetcla]

CLA signed by all contributors.

[ferventcoder]

👍