(PUP-3328) tidy should follow symlinks

[clehene]

No description provided.

[puppetcla]

Waiting for CLA signature by @clehene

@clehene - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppetlabs.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppetlabs.com/community/trivial_patch_exemption.html

[puppetcla]

CLA signed by all contributors.

[HAIL9000]

@MikaelSmith is going to look into this

[kylog]

First off, thanks for the contribution and kudos for providing an acceptance test!

Next, a few thoughts/questions?

• it makes me a bit uneasy for this to be the default - e.g. this might be a breaking change for some (unknowingly even)
• should this be an attribute on tidy?
• last, specs are failing - can you take a look?

@clehene thoughts on the above?

[kylog]

@clehene have you had a chance to take a look at the questions/comments above?

[branan]

I'm +1 with what kylo wrote. Having this follow symlinks by default makes me incredible nervous, and dropping that bomb onto users is a breaking change. I'd be very happy to see a follow_symlinks parameter on the tidy type.

[clehene]

Unfortunately no, and I'm not sure when / if I will.

On Mon, Aug 17, 2015 at 11:20 AM, Kylo Ginsberg notifications@github.com
wrote:

@clehene https://github.com/clehene have you had a chance to take a
look at the questions/comments above?

—
Reply to this email directly or view it on GitHub
#4084 (comment).

[branan]

@clehene I'm going to go ahead and close this for now since it's been inactive for a while. If/when you have time to pick it up feel free to re-open.

We'll keep the ticket open, since the general concept of following symlinks is a good enhancement request.

[clehene]

@branan Sorry I couldn't get back to this. I think closing for now is fine.
Thanks for pinging.