Fix insync? method for array_matching => all#413
Merged
slippycheeze merged 1 commit intopuppetlabs:2.7.xfrom Jan 26, 2012
Merged
Fix insync? method for array_matching => all#413slippycheeze merged 1 commit intopuppetlabs:2.7.xfrom
slippycheeze merged 1 commit intopuppetlabs:2.7.xfrom
Conversation
This reverts commit 48726b6. Revert the commit to use the old insync? method. Revert the commit due to the following different reasons: * the code does only work on ruby 1.9 as described in #12197 * the insync? method does not work for array comparisons if the should array has more items than the is array because smallarray.zip(bigarray) truncates bigarray * it is currently not possible to overwrite just the property_match? method because the insync method will then raise an exception Could not evaluate: old and new mismatch! While I guess there were good reasons behind the refactor of the insync? method it is currently quicker to just revert the commit than fixing the errors (and writing tests for it)
slippycheeze
added a commit
that referenced
this pull request
Jan 26, 2012
Fix insync? method for array_matching => all
Contributor
|
Wasn't this part of a larger changeset that included #2927 to support symbolic file modes? Do symbolic file modes not work now that this has been reverted? I'm actually somewhat surprised there were no test failures. |
tdevelioglu
pushed a commit
to tdevelioglu/puppet
that referenced
this pull request
Mar 29, 2016
melissa
pushed a commit
to melissa/puppet
that referenced
this pull request
Mar 30, 2018
Revert "(PCP-270) Remove outsourced pthread dependency"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 48726b6.
Revert the commit to use the old insync? method. Revert the commit
due to the following different reasons:
the should array has more items than the is array
because smallarray.zip(bigarray) truncates bigarray
method because the insync method will then raise an exception
Could not evaluate: old and new mismatch!
While I guess there were good reasons behind the refactor of the
insync? method it is currently quicker to just revert the commit than
fixing the errors (and writing tests for it)