(#3324) yumrepo doesn't support ssl options#423
(#3324) yumrepo doesn't support ssl options#423dieterdemeyer wants to merge 1 commit intopuppetlabs:masterfrom
Conversation
|
This looks like a good addition; working through some weirdness that I'm seeing when doing a full run of all of the specs, and if it's not related, I plan to merge this. |
|
The new test here started causing the specs to fail for me, but the failure turns out to be a bug in backups_spec.rb. That is fixed here: https://github.com/puppetlabs/puppet/pull/524/files Once that is merged, I believe that this change should be merged in as well. This branch is based on 2.7.x but I think it should probably go into master. One other thing: there are some tests that look fairly useful here: test/ral/type/yumrepo.rb If I end up being the one to merge this in, I'll probably try to port those from the old unit test area into this new yum_repo spec test... just didn't have time today. |
|
I've run the full suite of specs locally using the combination of this commit and the one referenced above (pull request 524), and they all pass for me. |
|
I created a new branch off of this commit, and took one extra step of porting the existing yumrepo unit tests over to specs. Closing this pull request for that one: |
(maint) Merge master to stable for release
The yumrepo resource doesn't support attributes for SSL authentication.
This patch adds the following ssl attributes to the yumrepo resource:
sslcacert, sslverify, sslclientcert and sslclientkey.
There was no RSpec test present for the yumrepo resource.
So I have added a new test case, containing tests for the current attributes and also for the new ssl options.