Skip to content

(#3324) yumrepo doesn't support ssl options#423

Closed
dieterdemeyer wants to merge 1 commit intopuppetlabs:masterfrom
dieterdemeyer:ticket/2.7.x/3324_yumrepo_does_not_support_ssl_options
Closed

(#3324) yumrepo doesn't support ssl options#423
dieterdemeyer wants to merge 1 commit intopuppetlabs:masterfrom
dieterdemeyer:ticket/2.7.x/3324_yumrepo_does_not_support_ssl_options

Conversation

@dieterdemeyer
Copy link
Copy Markdown
Contributor

The yumrepo resource doesn't support attributes for SSL authentication.
This patch adds the following ssl attributes to the yumrepo resource:
sslcacert, sslverify, sslclientcert and sslclientkey.

There was no RSpec test present for the yumrepo resource.
So I have added a new test case, containing tests for the current attributes and also for the new ssl options.

@cprice404
Copy link
Copy Markdown

This looks like a good addition; working through some weirdness that I'm seeing when doing a full run of all of the specs, and if it's not related, I plan to merge this.

@cprice404
Copy link
Copy Markdown

The new test here started causing the specs to fail for me, but the failure turns out to be a bug in backups_spec.rb. That is fixed here:

https://github.com/puppetlabs/puppet/pull/524/files

Once that is merged, I believe that this change should be merged in as well. This branch is based on 2.7.x but I think it should probably go into master.

One other thing: there are some tests that look fairly useful here:

test/ral/type/yumrepo.rb

If I end up being the one to merge this in, I'll probably try to port those from the old unit test area into this new yum_repo spec test... just didn't have time today.

@cprice404
Copy link
Copy Markdown

I've run the full suite of specs locally using the combination of this commit and the one referenced above (pull request 524), and they all pass for me.

@cprice404
Copy link
Copy Markdown

I created a new branch off of this commit, and took one extra step of porting the existing yumrepo unit tests over to specs. Closing this pull request for that one:

#534

@cprice404 cprice404 closed this Feb 28, 2012
melissa pushed a commit to melissa/puppet that referenced this pull request Mar 30, 2018
(maint) Merge master to stable for release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants