(PUP-4476) Call lookup with the correct parameters#4237
Merged
hlindberg merged 1 commit intopuppetlabs:masterfrom Sep 10, 2015
Merged
Conversation
Prior to this commit, the lookup application was calling the internal lookup function in a way that was compatible with the old version of the function (eight parameters) rather than the current version of the function (six parameters). This meant that attempts to use the lookup application would fail due to the function being called improperly. Fix this issue and also remove a test that had too much stubbing and was not longer useful.
Contributor
Author
|
I also think that Shaigy and I are seeing a but where the errors raised in run_command (e.g. when you don't include a node) are being raised but not appearing on the CLI. My guess is that puppet is putting them somewhere else, but I'm not sure what the correct way to raise an error is so that this doesn't happen. |
hlindberg
added a commit
that referenced
this pull request
Sep 10, 2015
…kup_with_correct_params (PUP-4476) Call lookup with the correct parameters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the lookup application was calling the internal
lookup function in a way that was compatible with the old version
of the function (eight parameters) rather than the current version
of the function (six parameters). This meant that attempts to use
the lookup application would fail due to the function being called
improperly.
Fix this issue and also remove a test that had too much stubbing
and was not longer useful.