(PUP-5022) update generator skeleton to new README template#4373
Closed
DavidS wants to merge 1 commit intopuppetlabs:masterfrom
Closed
(PUP-5022) update generator skeleton to new README template#4373DavidS wants to merge 1 commit intopuppetlabs:masterfrom
DavidS wants to merge 1 commit intopuppetlabs:masterfrom
Conversation
There was a problem hiding this comment.
Adjust the following numbers? Not strictly required markdown-wise, but increases cognitive load to see the sequence 1,3,4,... ("is something wrong here?").
If the concern is number of lines changed, you could make them all 1. and then never have this problem again :)
DavidS
force-pushed
the
pup-5022-update-README-skeleton
branch
from
3b7781f to
e73e362
Compare
Contributor
Author
|
Thanks for the comments. I seem to have to redo that copy&paste training ;-) |
Contributor
|
👍 |
Contributor
|
If this is required for 4.3.0, please retarget for stable |
Contributor
Author
|
PR'd a cherry-pick of this in #4426. Is that proper? |
Contributor
|
Thanks @DavidS. We will automatically merge the change from stable to master, so I'm going to close this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.