Merged
Conversation
Previously, puppet used ENV['TMP'], ENV['TEMP'], /tmp, etc as it's temp directory search path, using the first one that existed. It then used constant file names within the temp directory to re-write the files in ruby's bin directory, and bat wrappers on Windows. First, it leads to predictable temp file names, which is bad. Second, when installing puppet via a non-interactive ssh shell, e.g. ssh <host> ruby install.rb which is what the acceptance test harness does, the TMP and TEMP environment variables are usually not defined. So puppet was always defaulting to /tmp, which doesn't work when installing puppet on Windows agents during acceptance tests. This commit just changes the install script to use ruby's Tempfile to generate secure temp files that works in non-interactive shells.
melissa
pushed a commit
to melissa/puppet
that referenced
this pull request
Mar 30, 2018
(PCP-452) Add option to configure Association timeout
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, puppet used ENV['TMP'], ENV['TEMP'], /tmp, etc as it's
temp directory search path, using the first one that existed. It then
used constant file names within the temp directory to re-write the
files in ruby's bin directory, and bat wrappers on Windows.
First, it leads to predictable temp file names, which is bad. Second,
when installing puppet via a non-interactive ssh shell, e.g.
ssh <host> ruby install.rb
which is what the acceptance test harness does, the TMP and TEMP
environment variables are usually not defined. So puppet was always
defaulting to /tmp, which doesn't work when installing puppet on
Windows agents during acceptance tests.
This commit just changes the install script to use ruby's Tempfile to
generate secure temp files that works in non-interactive shells.