(PUP-5545) rubocop by default#4463
Conversation
|
Hey @ghoneycutt, it looks like the Rubocop check is now failing in Travis, could you take a quick look and see what's going on there? |
|
Hi @HAIL9000 Seems that the rubocop testing for puppet itself is using an older version and was attempting to read the .rubocop.yml file in the skeleton. I added a commit which tells the rubocop for the puppet project to ignore files in the puppet skeleton itself. https://github.com/puppetlabs/puppet/pull/4463/files#diff-11a0d7906801d9dea0eccb85667ad811R15 |
|
Don't merge yet.. I found some more additions to the configuration while testing another module that contained custom facts. I'll also need to run this over a module with custom types and providers to ensure it isn't suggesting changes for things that are common place in the community. |
|
Ping @andersonmills |
There was a problem hiding this comment.
I don't think we have a specified format yet, but voxpupuli has prior-art on this and it appears to be the same https://github.com/voxpupuli/modulesync_config/blob/master/moduleroot/.rubocop.yml 👍
|
Needs a rebase :( |
|
Hey @ghoneycutt, do you have some time to give this a quick rebase? Looks like there are merge conflicts |
|
Hey @ghoneycutt could you rebase? @andersonmills can you follow up and either merge when the changes become available or close if there is no activity? |
|
CLA signed by all contributors. |
ghoneycutt
force-pushed
the
PUP-5545-rubocop_by_default
branch
from
8565e71 to
ef014bd
Compare
|
Rebased |
|
I've opened a rebased PR at #4936 for @andersonmills to test. If it looks good we'll merge it, otherwise might have more requests for work. |
|
Closed in deference to #4936 |
9 participants
No description provided.