(PUP-5578) use exist? instead of '' to determine if scope key exists.#4482
Merged
thallgren merged 1 commit intopuppetlabs:masterfrom Dec 4, 2015
Merged
(PUP-5578) use exist? instead of '' to determine if scope key exists.#4482thallgren merged 1 commit intopuppetlabs:masterfrom
thallgren merged 1 commit intopuppetlabs:masterfrom
Conversation
Contributor
|
Looks good but a unit test is failing. You'll need to fix the last test in |
Contributor
|
Please make the commit comment start with |
thallgren
changed the title
…y exists in the scope (PUP-5578) fixed spec tests
Contributor
Author
|
@hlindberg @thallgren - commit renamed and spec tests improved to cover this.... |
thallgren
added a commit
that referenced
this pull request
Dec 4, 2015
(PUP-5578) use exist? instead of '' to determine if scope key exists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is the suggested fix for PUP-5578