Skip to content

Refactor/master/12309 posix util exec cleanup#454

Merged
slippycheeze merged 4 commits intopuppetlabs:masterfrom
cprice404:refactor/master/12309-posix-util-exec-cleanup
Feb 3, 2012
Merged

Refactor/master/12309 posix util exec cleanup#454
slippycheeze merged 4 commits intopuppetlabs:masterfrom
cprice404:refactor/master/12309-posix-util-exec-cleanup

Conversation

@cprice404
Copy link

  • moved "execute" related methods from Puppet::Util to Puppet::Util::Execute
  • moved some POSIX constants from Puppet::Util to Puppet::Util::POSIX
  • improved logic of Puppet.deprecation_warning
  • refactored (all?) deprecation warnings to call Puppet.deprecation_warning
  • refactored old usages of Puppet::Util.execute to use the new Puppet::Util::Execution.execute

There are still deprecated stubs for execpipe, execfail, and execute in Puppet::Util for backwards compatibility.  rspecs are all passing, but would still like to go through and check for deprecation warnings that were triggered by this changeset (and fix them, obviously).

get spec tests running against Puppet::Util -> Util::Execution refactor
* Improve logic of deprecation_warning
* Add utility method for logging deprecation warnings to a file
* Refactored all references of Puppet::Util.execute to call Puppet::Util::Execution.execute
slippycheeze added a commit that referenced this pull request Feb 3, 2012
…x-util-exec-cleanup

Refactor/master/12309 posix util exec cleanup
@slippycheeze slippycheeze merged commit 10fea32 into puppetlabs:master Feb 3, 2012
melissa pushed a commit to melissa/puppet that referenced this pull request Mar 30, 2018
…7-Acceptance_Automate_pxp-agent_broker_timeout_failover_test

(PCP-457) Acceptance: Automate pxp-agent broker timeout failover test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants