(#12404) Reduce redundant code in lib/puppet/application#455
Closed
jeffweiss wants to merge 1 commit intopuppetlabs:masterfrom
Closed
Conversation
Reduce redundant code by defining Puppet::Application.logdest_option, which can then be called from applications that need a log destination instead of copying the 9 lines of code specific to creating a log destination. Reduce redundant code by defining Puppet::Application.setup_logs to ease (and standardize) the log setup across the applications. Reduce redundant code by moving setup_host into Puppet::Application. Encapsulate logic for exiting if Puppet.settings.print_config? Encapsulate logic for sorting type providers in Puppet::Application::Describe. Modify tests to use standard option :setdest. Modify tests to mock options :setdest, :debug, and :verbose to handle standardized checked against each option in consolidated setup_logs method.
Contributor
|
@jeffweiss - I am looking at this, but it is a bigger change than I can immediately merge. I like the idea; most complexity is around "should we retain this choice", rather than anything in the code, so takes bigger thinking to answer. |
melissa
pushed a commit
to melissa/puppet
that referenced
this pull request
Mar 30, 2018
(maint) Fix gettext in Travis CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce redundant code by defining Puppet::Application.logdest_option,
which can then be called from applications that need a log destination
instead of copying the 9 lines of code specific to creating a log
destination.
Reduce redundant code by defining Puppet::Application.setup_logs
to ease (and standardize) the log setup across the applications.
Reduce redundant code by moving setup_host into Puppet::Application.
Encapsulate logic for exiting if Puppet.settings.print_config?
Encapsulate logic for sorting type providers in Puppet::Application::Describe.
Modify tests to use standard option :setdest.
Modify tests to mock options :setdest, :debug, and :verbose to
handle standardized checked against each option in consolidated
setup_logs method.