Ticket/2.7.x/12256 module tool core changes#503
Closed
mmrobins wants to merge 2 commits intopuppetlabs:2.7.xfrom
Closed
Ticket/2.7.x/12256 module tool core changes#503mmrobins wants to merge 2 commits intopuppetlabs:2.7.xfrom
mmrobins wants to merge 2 commits intopuppetlabs:2.7.xfrom
Conversation
Being able to figure out what other modules depend on a module is useful for resolving contraints when installing and preventing uninstalls of modules that are still required. And being able to tell if a module has local changes is useful to prevent accidentally losing those changes when upgrading or uninstalling a module.
Before this patch module requirements do not include version numbers. Since modules with the same name, but different version numbers, can be installed at the same time -- in different parts of the modulepath, there is no way to tell which module has the dependency. This patch fixes this issue by changing the data structure that represents module requirements from a two item Array to a Hash with three keys: name, version, and version_requirement. This patch includes updated spec tests related to this change.
melissa
pushed a commit
to melissa/puppet
that referenced
this pull request
Mar 30, 2018
(maint) Update maintainers file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the changes needed for the module tool that affect areas of code in other parts of Puppet.