(PUP-6774) Fix incorrect call to is_json_type in Puppet::Resource#5313
Merged
hlindberg merged 1 commit intopuppetlabs:masterfrom Oct 4, 2016
Merged
(PUP-6774) Fix incorrect call to is_json_type in Puppet::Resource#5313hlindberg merged 1 commit intopuppetlabs:masterfrom
is_json_type in Puppet::Resource#5313hlindberg merged 1 commit intopuppetlabs:masterfrom
Conversation
The actual method name is `is_json_type?`
Contributor
Author
|
Verified |
Contributor
Author
|
/cc @hlindberg or @thallgren, this will un-break CI |
Contributor
|
👍 |
hlindberg
approved these changes
Oct 4, 2016
Contributor
|
Since this didn't get caught by unit tests, it seems like we might have a test coverage gap - is that something that should be fixed either in this or in another PR soon-ish? |
Contributor
Author
|
@branan makes sense - I'd vote for a followup PR as this is just intended as an immediate fix to get CI passing again |
Contributor
|
@whopper I'm cool with that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actual method name is
is_json_type?