Skip to content

(PUP-6774) Fix incorrect call to is_json_type in Puppet::Resource#5313

Merged
hlindberg merged 1 commit intopuppetlabs:masterfrom
whopper:PUP-5834/json_type_method
Oct 4, 2016
Merged

(PUP-6774) Fix incorrect call to is_json_type in Puppet::Resource#5313
hlindberg merged 1 commit intopuppetlabs:masterfrom
whopper:PUP-5834/json_type_method

Conversation

@whopper
Copy link
Contributor

@whopper whopper commented Oct 4, 2016

The actual method name is is_json_type?

@whopper
Copy link
Contributor Author

whopper commented Oct 4, 2016

Verified environment/variables_refreshed_each_compilation.rb now passes:

      Test Suite: tests @ 2016-10-04 13:30:43 -0700

      - Host Configuration Summary -


              - Test Case Summary for suite 'tests' -
       Total Suite Time: 79.89 seconds
      Average Test Time: 79.89 seconds
              Attempted: 1
                 Passed: 1
                 Failed: 0
                Errored: 0
                Skipped: 0
                Pending: 0
                  Total: 1

      - Specific Test Case Status -

Beaker completed successfully, thanks.

@whopper
Copy link
Contributor Author

whopper commented Oct 4, 2016

/cc @hlindberg or @thallgren, this will un-break CI

@MosesMendoza
Copy link
Contributor

👍

@branan
Copy link
Contributor

branan commented Oct 4, 2016

Since this didn't get caught by unit tests, it seems like we might have a test coverage gap - is that something that should be fixed either in this or in another PR soon-ish?

@whopper
Copy link
Contributor Author

whopper commented Oct 4, 2016

@branan makes sense - I'd vote for a followup PR as this is just intended as an immediate fix to get CI passing again

@hlindberg hlindberg merged commit 3f109f3 into puppetlabs:master Oct 4, 2016
@branan
Copy link
Contributor

branan commented Oct 4, 2016

@whopper I'm cool with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants