(#12960) fix order dependent test failures over global state#568
Merged
pcarlisle merged 4 commits intopuppetlabs:2.7.xfrom Mar 8, 2012
slippycheeze:maint/2.7.x/12960-fix-order-dependent-test-failures-over-global-state
Merged
(#12960) fix order dependent test failures over global state#568pcarlisle merged 4 commits intopuppetlabs:2.7.xfrom slippycheeze:maint/2.7.x/12960-fix-order-dependent-test-failures-over-global-state
pcarlisle merged 4 commits intopuppetlabs:2.7.xfrom
slippycheeze:maint/2.7.x/12960-fix-order-dependent-test-failures-over-global-state
Conversation
added 4 commits
March 8, 2012 11:50
These methods were introduced, producing a pale shadow of the constraint system that we already had, as part of building out device support. Now that we are confident of the long term value of that support, and are looking to better integrate it, we should start cleaning up these older relics of the initial design. This flags, in a comment, what the problem is and what the solution should be, so that folks looking at the code get directed to the right sort of place. Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>
Expecting that a type by the name of "foo" doesn't exist is asking for trouble, because other tests are highly likely to create one. Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>
Using a common meta-name like "foo" in testing runs a risk that global state will lead down the path to things going wrong. In this case, it clashed with a type created elsewhere that lingered... Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>
Using a common name like `foo` runs the risk that things go terribly wrong; better to use something less likely to conflict. Now we expunged the other places this broke, this is safe to do. Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>
pcarlisle
added a commit
that referenced
this pull request
Mar 8, 2012
…er-dependent-test-failures-over-global-state (#12960) fix order dependent test failures over global state
melissa
pushed a commit
to melissa/puppet
that referenced
this pull request
Mar 30, 2018
(maint) Pin pcp-broker to latest release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had some order dependent test failures, caused by a type named
foobeing defined.Because we don't clean up global state to revoke those named types, we wind up in the position that we broke a bunch of other places that also created something named
foooverlapping the original - but only if they ran in the right order.(Which, unfortunately, still turns out to be "on CI, but not my workstation")