(Maint) Consistently use the same agent fqdn#581
Merged
slippycheeze merged 1 commit intopuppetlabs:2.7.xfrom Mar 15, 2012
Merged
(Maint) Consistently use the same agent fqdn#581slippycheeze merged 1 commit intopuppetlabs:2.7.xfrom
slippycheeze merged 1 commit intopuppetlabs:2.7.xfrom
Conversation
Previously, the test would always fail when the rhel6-32-1 box was
reverted to its `git` snapshot, and the test executed. The box, for
better or worse, reports the following:
[root@rhel6-32-1 ~]# hostname -f
rhel6-32-1
[root@rhel6-32-1 ~]# facter fqdn
rhel6-32-1.puppetlabs.lan
The agent submits its report using the latter, but the test attempts to
retrieve the facts using the former:
curl -k -H \"Accept: yaml\" https://rhel6-32-1:8140/override/facts/`hostname -f`"
And that always fails:
Could not find facts rhel6-32-1
This issue does not occur when running the non-Windows acceptance tests,
because those jobs run on centos-55-386-1 and ubuntu-1004-32-1, which
don't have inconsistency in their domain as reported by facter and
`hostname -f`
This commit changes the test to request the facts from the master using
the same fqdn that the agent used in its report.
slippycheeze
added a commit
that referenced
this pull request
Mar 15, 2012
(Maint) Consistently use the same agent fqdn
melissa
pushed a commit
to melissa/puppet
that referenced
this pull request
Mar 30, 2018
(packaging) Prepare for 1.5.2 release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the test would always fail when the rhel6-32-1 box was
reverted to its
gitsnapshot, and the test executed. The box, forbetter or worse, reports the following:
The agent submits its report using the latter, but the test attempts to
retrieve the facts using the former:
And that always fails:
This issue does not occur when running the non-Windows acceptance tests,
because those jobs run on centos-55-386-1 and ubuntu-1004-32-1, which
don't have inconsistency in their domain as reported by facter and
hostname -fThis commit changes the test to request the facts from the master using
the same fqdn that the agent used in its report.