2.7.x - fix for password setting on AIX user provider#585
Merged
kelseyhightower merged 1 commit intopuppetlabs:2.7.xfrom Jul 17, 2012
Merged
2.7.x - fix for password setting on AIX user provider#585kelseyhightower merged 1 commit intopuppetlabs:2.7.xfrom
kelseyhightower merged 1 commit intopuppetlabs:2.7.xfrom
Conversation
The user provider on AIX fails to set the password for local users using chpasswd. This commit includes the code in ticket #11200 suggested by Josh Cooper. It works in my environment (AIX 5.3 + 6.1). chpasswd can also return 1 even on success; it's not clear if this is by design, as the manpage doesn't mention it. The lack of output from chpasswd indicates success; if there's a problem it dumps output to stderr/stdout.
|
@andytinycat Thanks for the patch! Also can you include some updated spec tests for this change? |
Author
|
@kelseyhightower I'm not familiar with unit testing in Ruby, but I guess this is a good opportunity to learn. From what I can see, there are no unit tests for the AIX user provider at all; which means writing a full set of tests to validate its behaviour. Is that acceptable within a single pull, or should I split the tests up into a new ticket+pull pair? |
|
@andytinycat A single pull requests works for me. If you get stuck writing the unit tests let me know. |
|
This patch is a hard one to test indeed. Overall the code looks ok and I cannot think of a better way to do this. |
kelseyhightower
pushed a commit
that referenced
this pull request
Jul 17, 2012
2.7.x - fix for password setting on AIX user provider
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The user provider on AIX fails to set the password for local users
using chpasswd.
This commit includes the code in ticket #11200 suggested by Josh
Cooper. It works in my environment (AIX 5.3 + 6.1).
chpasswd can also return 1 even on success; it's not clear if this is
by design, as the manpage doesn't mention it. The lack of output from
chpasswd indicates success; if there's a problem it dumps output to
stderr/stdout.