(#13584) master swallows errors during startup#619
Closed
cprice404 wants to merge 1 commit intopuppetlabs:masterfrom
Closed
(#13584) master swallows errors during startup#619cprice404 wants to merge 1 commit intopuppetlabs:masterfrom
cprice404 wants to merge 1 commit intopuppetlabs:masterfrom
Conversation
Our main "exit_on_fail" method was only catching and logging a limited subset of all possible errors; this was preventing some types of errors (e.g. File Access errors) from being logged, which makes it much more difficult to troubleshoot failures on CI and other locations.
Author
|
This doesn't seem to be entirely copacetic w/acceptance tests yet; closing, will re-open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our main "exit_on_fail" method was only catching
and logging a limited subset of all possible errors;
this was preventing some types of errors (e.g.
File Access errors) from being logged, which makes
it much more difficult to troubleshoot failures
on CI and other locations.