Add pip3.exe for windows to work properly

[dverenzuela]

Using this provider in windows fails because can't locate pip3. pip3.exe needs to be specified.

[joshcooper]

Thanks for the contribution @dverenzuela! One thing I'm not understanding is that puppet should already try to resolve the path based on the PATHEXT environment variable, which by default includes ".exe", see https://github.com/puppetlabs/puppet/blob/master/lib/puppet/util.rb#L247-L249. Could you dig into that and see why that part isn't sufficient?

[dverenzuela]

Hello @joshcooper thanks for your quick reply. Actually I’m not sure why is not expanding the cmd. Seeing the pip package provider which is required by pip3 is defined the pip.exe for Windows case. That’s why after trying different workarounds With path variables and others I just decided to have a look to the provider code and I figured that it was looking for pip3 and not pip3.exe as soon as I copied it works. Maybe could be because of windows 10 + puppet agent v1.9.3?

[puppetcla]

CLA signed by all contributors.

[melissa]

@dverenzuela have you had a chance to look at this? Digging into it I can't reproduce the issue you're having. I've installed puppet-agent 5.3.3 which provides puppet 5.3.3. It successfully finds pip3.exe without this change.

Since you said you're using puppet-agent 1.9.3, it looks like that include puppet 4.9.4, which has all the functionality Josh pointed to in his earlier comment. It should still be able to find the pip3 command without specifying the .exe extension.

Is there a possibility you have multiple pip3{.exe,.bat} files on the system? It looks like that previously was an issue with pip (see https://tickets.puppetlabs.com/browse/PUP-6895), though it doesn't seem like we'd have the same problem with pip3, unless perl also provides a pip3 executable.

[melissa]

Since this hasn't seen any activity in over two months, I'm going to go ahead and close this pull request for the time being. Please re-open this pull request once the next actions are addressed, new information is available, or you have a question related to this pull request. We've become aware of difficulties re-opening pull requests, in the event you cannot please mention melissa with an @ sign in front and we'll re-open this pull request.

Closing the pull request doesn't mean we don't consider this change valuable, just that there are things that need to be addressed before it can be merged. If you have any questions or concerns, please don't hesitate to ping us in slack.puppet.com.