(#13655) Fixup tests to work on CentOS 5#637
Merged
cprice404 merged 1 commit intopuppetlabs:masterfrom Apr 6, 2012
Merged
Conversation
Several tests were failing because the depended on being able to find a user provider. On CentOS 5 this didn't work because the provider that should be used (the useradd provider) is not considered suitable when it gets run as a non-privaleged user because the useradd and related commands are not executable. The user_spec.rb and group_spec.rb test didn't need the tests that were failing because they were testing functionality that is already tested by the Type base class's own tests. The ral_spec.rb needed more mocking of the things it was using in order to abstract it from the system on which it is running. The resources_spec.rb got a small cleanup and was fixed by reordering the data loading in Puppet::Type::Resources so that it doesn't load information about a user until it needs to.
|
This looks very straightforward, is almost entirely test cleanup / improvements. Running specs and acceptance locally now. |
cprice404
added a commit
that referenced
this pull request
Apr 6, 2012
…on-centos5 (#13655) Fixup tests to work on CentOS 5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several tests were failing because the depended on being able to find a
user provider. On CentOS 5 this didn't work because the provider that
should be used (the useradd provider) is not considered suitable when it
gets run as a non-privaleged user because the useradd and related
commands are not executable.
The user_spec.rb and group_spec.rb test didn't need the tests that were
failing because they were testing functionality that is already tested
by the Type base class's own tests.
The ral_spec.rb needed more mocking of the things it was using in order
to abstract it from the system on which it is running.
The resources_spec.rb got a small cleanup and was fixed by reordering
the data loading in Puppet::Type::Resources so that it doesn't load
information about a user until it needs to.