(PUP-7937) Add missing period to exception message in certificate_authority.rb#6375
Merged
ericldelaney merged 1 commit intopuppetlabs:masterfrom Nov 21, 2017
nrwahl2:fix/master/nwahl-add_missing_punctuation
Merged
(PUP-7937) Add missing period to exception message in certificate_authority.rb#6375ericldelaney merged 1 commit intopuppetlabs:masterfrom nrwahl2:fix/master/nwahl-add_missing_punctuation
ericldelaney merged 1 commit intopuppetlabs:masterfrom
nrwahl2:fix/master/nwahl-add_missing_punctuation
Conversation
| # Check for wildcards in the subjectAltName fields too. | ||
| if csr.subject_alt_names.any? {|x| x.include? '*' } | ||
| raise CertificateSigningError.new(hostname), _("CSR '%{csr}' subjectAltName contains a wildcard, which is not allowed: %{alt_names} To continue, this CSR needs to be cleaned.") % { csr: csr.name, alt_names: csr.subject_alt_names.join(', ') } | ||
| raise CertificateSigningError.new(hostname), _("CSR '%{csr}' subjectAltName contains a wildcard, which is not allowed: %{alt_names}. To continue, this CSR needs to be cleaned.") % { csr: csr.name, alt_names: csr.subject_alt_names.join(', ') } |
There was a problem hiding this comment.
Looks like your editor converted the spaces into a tab.
Contributor
Author
|
Odd. My editor is vim and I've never had that happen before. It'll be a few hours before I can get home and fix it. You're welcome to take it over if you want.
Sent from ProtonMail mobile
…-------- Original Message --------
On Nov 20, 2017, 11:37, ericldelaney wrote:
@ericldelaney commented on this pull request.
---------------------------------------------------------------
In [lib/puppet/ssl/certificate_authority.rb](#6375 (comment)):
> @@ -399,7 +399,7 @@ def check_internal_signing_policies(hostname, csr, options = {})
# Check for wildcards in the subjectAltName fields too.
if csr.subject_alt_names.any? {|x| x.include? '*' }
- raise CertificateSigningError.new(hostname), _("CSR '%{csr}' subjectAltName contains a wildcard, which is not allowed: %{alt_names} To continue, this CSR needs to be cleaned.") % { csr: csr.name, alt_names: csr.subject_alt_names.join(', ') }
+ raise CertificateSigningError.new(hostname), _("CSR '%{csr}' subjectAltName contains a wildcard, which is not allowed: %{alt_names}. To continue, this CSR needs to be cleaned.") % { csr: csr.name, alt_names: csr.subject_alt_names.join(', ') }
Looks like your editor converted the spaces into a tab.
—
You are receiving this because you authored the thread.
Reply to this email directly, [view it on GitHub](#6375 (review)), or [mute the thread](https://github.com/notifications/unsubscribe-auth/AdEzNaKfBc45CgoilvA_KNGZeTYFYi3oks5s4bjugaJpZM4Qkk5H).
|
|
CLA signed by all contributors. |
…hority.rb An exception message in certificate_authority.rb is missing a period between sentences. This patch simply adds that missing punctuation.
Contributor
Author
|
@ericldelaney should be good after builds run. We shall see. |
ericldelaney
approved these changes
Nov 21, 2017
|
@nrwahl2 Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An exception message in certificate_authority.rb is missing a period
between sentences. This patch simply adds that missing punctuation.