Schedule/feature/13054 rangespan rebase#642
Merged
jeffweiss merged 3 commits intopuppetlabs:masterfrom Apr 10, 2012
Merged
Conversation
Allow schedule ranges to span the midnight boundary properly. For instance, for a 9 PM to 3 AM change window you can simply state "range => '21:00 - 03:00'" instead of "range => ['21:00 - 23:59', '00:00 - 03:00' ]"
Part 2, adjust for the special adjustments needed to properly handle the day-of-week parameter when spanning days.
Per Kelsey Hightower's suggestion, move the multiple 'include ScheduleTesting' statements in the specfile to the parent parent describe block.
Contributor
Contributor
Author
|
@jeffweiss Thanks, I've closed the prior pull request. Let me know if I can do anything else on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I rebased on master after discussion and approval of the feature submission I originally put in pull request 574: #574
This should be clean to apply on the current master branch.
Cheers!