(maint) Remove unnecessary step from puppet module build help #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch the `puppet help module build` command says to make sure the module directory is in the form of <username>-<modulename>. This is an unnecessary step because it isn't actually necessary anymore. It's a problem because we want to make things appear to be as simple as they actually are, not more complex than they need to be. I just tested this with a module existing at /vagrant/modules/jenkins (no symlinks) using the command: `puppet module build .` Everything worked out fine. Puppet correctly reads the Modulefile and figures out the author name. This is a documentation only change.
slippycheeze
added a commit
that referenced
this pull request
Apr 10, 2012
…ld_help (maint) Remove unnecessary step from puppet module build help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this patch the
puppet help module buildcommand says to makesure the module directory is in the form of -.
This is an unnecessary step because it isn't actually necessary anymore.
It's a problem because we want to make things appear to be as simple as
they actually are, not more complex than they need to be.
I just tested this with a module existing at /vagrant/modules/jenkins
(no symlinks) using the command:
puppet module build .Everything worked out fine. Puppet correctly reads the Modulefile and
figures out the author name.
This is a documentation only change.