(#13204) Don't ignore missing PATH.augnew files#660
Merged
jeffweiss merged 1 commit intopuppetlabs:2.7.xfrom Apr 12, 2012
Merged
Conversation
The original fix for #13204 may have masked other potential bugs if the PATH.augnew file was missing. It simply tested for the file existance and not only when duplicate save events occurred. This change de-duplicates the list of save events instead, so if a bug appeared where PATH.augnew was genuinely missing, the error wouldn't be squashed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to pull req #587, where a better solution was discussed that doesn't squash other errors.
Commit log:
The original fix for #13204 may have masked other potential bugs if the
PATH.augnew file was missing. It simply tested for the file existance and not
only when duplicate save events occurred.
This change de-duplicates the list of save events instead, so if a bug appeared
where PATH.augnew was genuinely missing, the error wouldn't be squashed.