(maint) Get provider specs working on windows#689
Closed
jeffweiss wants to merge 2 commits intopuppetlabs:masterfrom
Closed
(maint) Get provider specs working on windows#689jeffweiss wants to merge 2 commits intopuppetlabs:masterfrom
jeffweiss wants to merge 2 commits intopuppetlabs:masterfrom
Conversation
added 2 commits
April 19, 2012 09:39
Define helper to provider an existing command for windows because "echo" is a shell interpreted command, not a proper executable. As a side note, a helper method was the only way this actually functions because of the evaluation context of the confine scenarios hash. Let, before(:each), and instance variable all fail.
Change to Puppet.features.microsoft_windows? for OS test.
Contributor
|
Thanks Jeff. I squashed the commits and pushed the change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define helper to provider an existing command for windows because "echo"
is a shell interpreted command, not a proper executable.
As a side note, a helper method was the only way this actually functions
because of the evaluation context of the confine scenarios hash. Let,
before(:each), and instance variable all fail.