(PUP-8988) Define vendormoduledir as a string#6939
Merged
jhelwig merged 1 commit intopuppetlabs:masterfrom Jul 25, 2018
Merged
Conversation
Contributor
Author
|
/cc @rbrw |
joshcooper
force-pushed
the
PUP8988-use-string-setting
branch
2 times, most recently
from
c817a59 to
2755ce9
Compare
|
CLA signed by all contributors. |
melissa
approved these changes
Jul 24, 2018
Contributor
Author
|
jenkins please test this on windows2012r2-64a |
Calling `Puppet.settings.use(<section>)` will create files and directories for all of the `:file` and `:directory` based settings in that section. Previously, running `puppet lookup` as a non-root user failed, because lookup uses the `master` section, the `vendormodulesdir` setting is defined in the `master` section, and the user did not have permission to create the `/opt/puppetlabs/puppet/vendor_modules` directory. This commit changes the vendormoduledir setting to be of type `:string`. This way puppet never tries to manage its existence via a settings catalog. It doesn't use `:path`, because that settings type is reserved for settings that allow multiple directories separated by File::PATH_SEPARATOR.
joshcooper
force-pushed
the
PUP8988-use-string-setting
branch
from
2755ce9 to
d61d834
Compare
Contributor
Author
|
The build failed because the PR didn't include the revert of the mount type/provider. I rebased on master. |
Contributor
Author
|
jenkins please test this on windows2012r2-64a |
jhelwig
approved these changes
Jul 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
Puppet.settings.use(<section>)will create files and directoriesfor all of the
:fileand:directorybased settings in that section.Previously, running
puppet lookupas a non-root user failed, becauselookup uses the
mastersection, thevendormodulesdirsetting isdefined in the
mastersection, and the user did not have permission tocreate the
/opt/puppetlabs/puppet/vendor_modulesdirectory.This commit changes the vendormoduledir setting to be of type
:string.This way puppet never tries to manage its existence via a settings
catalog. It doesn't use
:path, because that settings type is reservedfor settings that allow multiple directories separated by
File::PATH_SEPARATOR.