(#12392): Colorize console output on Windows #707
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `Puppet[:color]` was false on Windows, because the Windows console does not support ANSI escape sequences. The win32console gem converts ANSI color escape sequences into Win32 console API calls to change the foreground color, etc. If the output stream has been redirected to a file, then the gem does not translate the sequences, instead preserving them in the stream, as is done on Unix. To disable colorized output specify `color=false` or `--color=false` on the command line. This commit adds a `Puppet.features.ansicolor?` feature that defines whether ANSI color escape sequences are supported. On Windows, this is only true if the win32console gem can be loaded. On other platforms, the value is always true. The win32console gem will be packaged into the Windows installer, and so, `Puppet[:color]` now defaults to true. If the gem can't be loaded, then puppet will revert to its previous behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
Puppet[:color]was false on Windows, because the Windowsconsole does not support ANSI escape sequences.
The win32console gem converts ANSI color escape sequences into Win32
console API calls to change the foreground color, etc. If the output
stream has been redirected to a file, then the gem does not translate
the sequences, instead preserving them in the stream, as is done on
Unix.
To disable colorized output specify
color=falseor--color=falseonthe command line.
This commit adds a
Puppet.features.ansicolor?feature that defineswhether ANSI color escape sequences are supported. On Windows, this is
only true if the win32console gem can be loaded. On other platforms, the
value is always true.
The win32console gem will be packaged into the Windows installer, and
so,
Puppet[:color]now defaults to true. If the gem can't be loaded,then puppet will revert to its previous behavior.