(PUP-9497) Deprecate fine grained control of file and environment tim…

[melissa]

…eouts

[puppetcla]

CLA signed by all contributors.

[melissa]

$ be ./bin/puppet config print environment_timeout filetimeout
Warning:             Fine grained control of filetimeouts is deprecated. In future
            releases this value will only determine if file content is cached.

            Valid values will be 0 (never cache) and 'unlimited' (always cache).
            With a default of 'unlimited'.

   (location: /Users/Melissa/puppet/lib/puppet/defaults.rb:613:in `block in <module:Puppet>')
Warning:           Fine grained control of environment timeouts is deprecated,
          please use `0` or `unlimited` to control default caching behavior
          and the environment-cache endpoint in Puppet Server's administrative
          API to expire the cache as needed

   (location: /Users/Melissa/puppet/lib/puppet/defaults.rb:651:in `block in <module:Puppet>')
environment_timeout = 20
filetimeout = 20

[melissa]

and with the default values:

$ be ./bin/puppet config print environment_timeout filetimeout
environment_timeout = 0
filetimeout = 15

[melissa]

@justinstoller @Magisus can we get confirmation that we still want these deprecation warnings to land in 6.y, and the associated removals will happen in puppet 7.y?

[justinstoller]

Yes.

I doubt we can confirm right now that we will be building the feature for 7.0 that required this change. But everyone I discussed it with considered the current behavior buggy and misleading, and this change valuable regardless.

[joshcooper]

This should be a squiggly heredoc <<~WARNING so that the leftmost whitespace is trimmed

[joshcooper]

same

[melissa]

$ be ./bin/puppet config print environment_timeout filetimeout
Warning: Fine grained control of filetimeouts is deprecated. In future
releases this value will only determine if file content is cached.

Valid values will be 0 (never cache) and 'unlimited' (always cache).
With a default of 'unlimited'.

   (location: /Users/Melissa/puppet/lib/puppet/defaults.rb:613:in `block in <module:Puppet>')
Warning: Fine grained control of environment timeouts is deprecated,
please use `0` or `unlimited` to control default caching behavior
and the environment-cache endpoint in Puppet Server's administrative
API to expire the cache as needed

   (location: /Users/Melissa/puppet/lib/puppet/defaults.rb:651:in `block in <module:Puppet>')
environment_timeout = 20
filetimeout = 20

@joshcooper updated

[melissa]

$ be ./bin/puppet config print environment_timeout filetimeout
Warning: Fine grained control of filetimeouts is deprecated. In future
releases this value will only determine if file content is cached.

Valid values will be 0 (never cache) and 'unlimited' (always cache).
With a default of 'unlimited'.

   (location: /Users/Melissa/puppet/lib/puppet/defaults.rb:613:in `block in <module:Puppet>')
Warning: Fine grained control of environment timeouts is deprecated,
please use `0` or `unlimited` to control default caching behavior
and the environment-cache endpoint in Puppet Server's administrative
API to expire the cache as needed

   (location: /Users/Melissa/puppet/lib/puppet/defaults.rb:651:in `block in <module:Puppet>')
environment_timeout = 20
filetimeout = 20