(PUP-9564) Fix package update on resource held#7489
Merged
gimmyxd merged 1 commit intopuppetlabs:5.5.xfrom May 14, 2019
alexandru-d-popa:5.5.x
Merged
(PUP-9564) Fix package update on resource held#7489gimmyxd merged 1 commit intopuppetlabs:5.5.xfrom alexandru-d-popa:5.5.x
gimmyxd merged 1 commit intopuppetlabs:5.5.xfrom
alexandru-d-popa:5.5.x
Conversation
alexandru-d-popa
requested review from
a team,
gimmyxd,
jhelwig and
sebastian-miclea
tavilarion
reviewed
Apr 18, 2019
tavilarion
reviewed
Apr 18, 2019
tavilarion
reviewed
Apr 18, 2019
|
CLA signed by all contributors. |
gimmyxd
reviewed
Apr 19, 2019
gimmyxd
reviewed
May 7, 2019
gimmyxd
reviewed
May 7, 2019
gimmyxd
reviewed
May 7, 2019
acceptance/tests/provider/package/dpkg_ensure_held_package_is_latest.rb
Outdated
Show resolved
Hide resolved
gimmyxd
reviewed
May 7, 2019
gimmyxd
reviewed
May 7, 2019
gimmyxd
reviewed
May 7, 2019
gimmyxd
reviewed
May 7, 2019
acceptance/tests/provider/package/dpkg_ensure_held_package_should_preserve_version.rb
Outdated
Show resolved
Hide resolved
jhelwig
reviewed
May 9, 2019
This PR fixes the following bug: When setting a package to held first it checks if the package is installed on the system, if true then it only sets it's state to held, if false then it installs the latest package and after it sets it's state to held. Before this it would install the latest package and after that the state would change to held.
jhelwig
approved these changes
May 10, 2019
gimmyxd
approved these changes
May 14, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following bug:
When setting a package to held first it checks if the package is installed on the system, if true then it only sets it's state to held, if false then it installs the latest package and after it sets it's state to held.
Before this it would install the latest package and after that the state would change to held.