(PUP-8215) Don't expand skip_tags

[Jakski]

Don't split tags in skip_tags on namespace separator.

I noticed this issue in Puppet 5.4.0 and I was able to reproduce it on master branch(e1aee1ccb17a49798f3dae90172e7cb0b9c8518f). My patch makes skip_tags behave similarly to tags option. Let me know, if you would like to change/add anything, before you consider merging.

Example

Manifest:

class l1 {
  contain l1::l2_1
  contain l1::l2_2
  file { '/home/jakub/test':
    ensure => directory,
  }
}

class l1::l2_1 {
  file { '/home/jakub/test/l2_1':
    ensure => present,
  }
}

class l1::l2_2 {
  file { '/home/jakub/test/l2_2':
    ensure => present,
  }
}

include l1

Running without patch:

$ bundle exec puppet apply test.pp --skip_tags l1::l2_1 --debug | grep 'Skipping with skip tags'
Debug: Class[L1]: Skipping with skip tags l1::l2_1, l1, l2_1
Debug: Class[L1::L2_1]: Skipping with skip tags l1::l2_1, l1, l2_1
Debug: Class[L1::L2_2]: Skipping with skip tags l1::l2_1, l1, l2_1
Debug: /Stage[main]/L1/File[/home/jakub/test]: Skipping with skip tags l1::l2_1, l1, l2_1
Debug: /Stage[main]/L1::L2_1/File[/home/jakub/test/l2_1]: Skipping with skip tags l1::l2_1, l1, l2_1
Debug: Class[L1::L2_1]: Skipping with skip tags l1::l2_1, l1, l2_1
Debug: /Stage[main]/L1::L2_2/File[/home/jakub/test/l2_2]: Skipping with skip tags l1::l2_1, l1, l2_1
Debug: Class[L1::L2_2]: Skipping with skip tags l1::l2_1, l1, l2_1
Debug: Class[L1]: Skipping with skip tags l1::l2_1, l1, l2_1

Running with patch:

$ bundle exec puppet apply test.pp --skip_tags l1::l2_1 --debug | grep 'Skipping with skip tags'
Debug: Class[L1::L2_1]: Skipping with skip tags l1::l2_1
Debug: /Stage[main]/L1::L2_1/File[/home/jakub/test/l2_1]: Skipping with skip tags l1::l2_1
Debug: Class[L1::L2_1]: Skipping with skip tags l1::l2_1

[puppetlabs-jenkins]

Can one of the admins verify this patch?

[puppetcla]

Waiting for CLA signature by @Jakski

@Jakski - We require a Contributor License Agreement (CLA) for people who contribute to Puppet, but we have an easy click-through license with instructions, which is available at https://cla.puppet.com/

Note: if your contribution is trivial and you think it may be exempt from the CLA, please post a short reply to this comment with details. http://docs.puppet.com/community/trivial_patch_exemption.html

[jhelwig]

@Jakski The change looks reasonable, but we should definitely have a test for this to make sure that it doesn't regress again in the future. Feel free to let me know if you'd like a hand, or any pointers in setting up a unit test for this as it doesn't look like Puppet::Util::SkipTags has any existing unit tests to add on to.

[Jakski]

@jhelwig Thank you for reply. I added spec/unit/util/skip_tags_spec.rb to cover this case. Please review my changes.

[jhelwig]

jenkins please test this

[jhelwig]

@Jakski Thanks for all your work on this!

[gdubicki]

In which puppet 5.x version this will be released?

[joshcooper]

@gdubicki this change was merged to master and will be released in 6.5.0, to be released real soon now.