(#3909) Strip trailing dot from default FQDN #751
Conversation
|
This is a breaking change for Telly. I need to double check the acceptance tests to see if any of them need to change. |
|
Note: This may change the default certname (because now it strips out a trailing .) (That's why it's a breaking change) Running acceptance tests now |
|
I'm getting acceptance test failures on this, but they seem to be related to the hiera library being absent. Updating acceptance test framework and trying again. |
|
This needs tests before you add it ... because the change doesn't work. It discards the modified value, and fqdn remains what it was before. :) |
|
Wait... Shouldn't we support a default domain ending in a period? |
|
We're looking for a better place to put this, where we can actually test to see if it works. |
In Facter pull request 200 the default domian can no longer end with a trailing '.'. This modifies Puppet's defaults to mirror that change.
Move certname logic out of defaults.rb so that the logic can be tested because it's nearly impossible to test when that logic is executed at readtime for defaults.rb.
|
Moved the core logic to Puppet::Settings so that we can create tests. Trying to test off defaults.rb was almost impossible. |
4 participants
In Facter pull request 200 the default domian can no longer end
with a trailing '.'. This modifies Puppet's defaults to mirror
that change.