Skip to content

(PUP-9727) Reduce specificity of gem, pip providers#7544

Merged
mihaibuzgau merged 1 commit intopuppetlabs:5.5.xfrom
gimmyxd:maint/tune_specificity
Jun 3, 2019
Merged

(PUP-9727) Reduce specificity of gem, pip providers#7544
mihaibuzgau merged 1 commit intopuppetlabs:5.5.xfrom
gimmyxd:maint/tune_specificity

Conversation

@gimmyxd
Copy link
Contributor

@gimmyxd gimmyxd commented May 31, 2019

Due to the recent changes on package providers, when
no default package provider is explicitly set it will
always fallback to gem/puppet_gem/pip/pip3 because of the way
that specificity is calculated for a system which does
not have a default(the match expresion and number of ancestors)

Since those are specific language package managers,
their specificity was lowered to 1 if none of those providers
are set as default provider, otherwise the specficity
is calculated like it was before.

Due to the recent changes on package providers, when
no default package provider is explicitly set it will
always fallback to gem/puppet_gem/pip/pip3 because of the way
that specificity is calculated for a system which does
not have a default(the match expresion and number of ancestors)

Since those are specific language package managers,
their specificity was lowered to 1 if none of those providers
are set as default provider, otherwise the specficity
is calculated like it was before.
@gimmyxd gimmyxd requested review from a team and tkishel May 31, 2019 10:00
@puppetcla
Copy link

CLA signed by all contributors.

@gimmyxd gimmyxd changed the title (maint) Reduce specificity of gem, pip providers (PUP-9727) Reduce specificity of gem, pip providers May 31, 2019
@gimmyxd
Copy link
Contributor Author

gimmyxd commented May 31, 2019

ad hoc build: https://jenkins-master-prod-1.delivery.puppetlabs.net/view/Adhoc/job/platform_puppet-agent-extra_puppet-agent-integration-suite_adhoc-ad_hoc/602/

There are some errors which do not seem related to the package providers changes

@joshcooper
Copy link
Contributor

The debian puppet failure is due to PUP-9564

Copy link
Contributor

@joshcooper joshcooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some concerns about changing the specificity of gem and pip providers, as it feels like a breaking change. But as far as I'm aware, none of those providers are the default for any platform. So it's unlikely that:

package { 'something': }

Would have ever worked for gem/pip/etc. In other words, people would have had to specify the provider explicitly, and this PR doesn't change that behavior.

@mihaibuzgau mihaibuzgau merged commit a433c52 into puppetlabs:5.5.x Jun 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants