(PUP-9727) Reduce specificity of gem, pip providers#7544
Merged
mihaibuzgau merged 1 commit intopuppetlabs:5.5.xfrom Jun 3, 2019
Merged
(PUP-9727) Reduce specificity of gem, pip providers#7544mihaibuzgau merged 1 commit intopuppetlabs:5.5.xfrom
mihaibuzgau merged 1 commit intopuppetlabs:5.5.xfrom
Conversation
Due to the recent changes on package providers, when no default package provider is explicitly set it will always fallback to gem/puppet_gem/pip/pip3 because of the way that specificity is calculated for a system which does not have a default(the match expresion and number of ancestors) Since those are specific language package managers, their specificity was lowered to 1 if none of those providers are set as default provider, otherwise the specficity is calculated like it was before.
|
CLA signed by all contributors. |
Contributor
Author
|
There are some errors which do not seem related to the package providers changes |
Contributor
|
The debian puppet failure is due to PUP-9564 |
joshcooper
approved these changes
Jun 3, 2019
Contributor
joshcooper
left a comment
There was a problem hiding this comment.
I had some concerns about changing the specificity of gem and pip providers, as it feels like a breaking change. But as far as I'm aware, none of those providers are the default for any platform. So it's unlikely that:
package { 'something': }Would have ever worked for gem/pip/etc. In other words, people would have had to specify the provider explicitly, and this PR doesn't change that behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the recent changes on package providers, when
no default package provider is explicitly set it will
always fallback to gem/puppet_gem/pip/pip3 because of the way
that specificity is calculated for a system which does
not have a default(the match expresion and number of ancestors)
Since those are specific language package managers,
their specificity was lowered to 1 if none of those providers
are set as default provider, otherwise the specficity
is calculated like it was before.