Bug/master/13559 two console output styles enter one style leaves#761
Merged
slippycheeze merged 3 commits intopuppetlabs:masterfrom May 11, 2012
Conversation
Author
|
running acceptance on this locally right now. |
Author
|
I still get 5 failures on this. |
Author
|
will look into them shortly, working on an issue for 2.7.x / haus right now |
The acceptance test for overriding the agent name fact was broken, in that it
assumed that `exec { "echo foo": }` would always write `foo` to the output
channel.
This isn't true - on success, that output was simply hidden. By requesting
that output be logged we can ensure that message will show up and fix the
problem.
Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>
This makes the prototype new console the official, default, system-wide console in Puppet. This has some small, visible effects on error reporting across the board, but more importantly sets the stage for broader changes to improve user experience on the command line in future. Signed-off-by: Daniel Pittman <daniel@puppetlabs.com>
slippycheeze
added a commit
that referenced
this pull request
May 11, 2012
…le-output-styles-enter-one-style-leaves Bug/master/13559 two console output styles enter one style leaves
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just adds one commit to Daniel's previous series, to make sure that we log the context with a log message if there is one.