PUP-8949 use install_options with 'latest' methods#7633
PUP-8949 use install_options with 'latest' methods#7633ciprianbadescu merged 3 commits intopuppetlabs:5.5.xfrom
Conversation
|
CLA signed by all contributors. |
Prior to this commit ... The 'latest_with_new_pip' and 'latest_with_old_pip methods' (called by the 'latest' method) failed to execute `pip install` with the resource's `install_options` attribute, potentially resulting in a lack of idempotency. With this commit ... Any 'install_options' are applied whenever 'install' is executed.
tkishel
force-pushed
the
PUP-8949_use_install_options_with_latest
branch
from
c4de29b to
78a68c6
Compare
|
jenkins please test this on debian8-64a,debian8-32a,debian9-64a,debian9-32a,fedora28-64a,fedora29-64a,osx1012-64a,osx1013-64a,osx1014-64a,redhat5-64a,centos6-64a,centos6-32a,redhat7-64a,redhat8-64a,redhatfips7-64a,sles11-64a,sles11-32a,sles12-64a,sles12-POWERa,sles15-64a,solaris10-64a,solaris114-64a,ubuntu1404-64a,ubuntu1404-32a,ubuntu1604-64a,ubuntu1604-32a,ubuntu1804-64a,windows2016-64a,windows2019-64a |
|
looks good, please add rspec/acceptance tests |
add spec tests for latest with install_options
|
I've added unit tests, but would need help with acceptance tests as none exist now. |
|
We are generally missing acceptance tests for package managers ... |
|
I added a commit with potential acceptance tests. |
tkishel
force-pushed
the
PUP-8949_use_install_options_with_latest
branch
5 times, most recently
from
e3d13d5 to
5dec16c
Compare
|
I’ve added multiple acceptance tests. If the others need to be broken out into another PR, or they need to be refactored, please let me know.
Since language package (gem, pip, etc.) management is not specific to an operating system, it should not need to be tested on multiple os-es. The pip tests do need the EPEL repo to install pip, and that install is os-specific. If there is a better way to limit these tests other than ` confine :to, :platform => /centos|el/` please let me know.
|
tkishel
force-pushed
the
PUP-8949_use_install_options_with_latest
branch
12 times, most recently
from
9838b7f to
b84af98
Compare
|
There is a potential issue or two with PATH in our acceptance test environment ... documented in comments in |
tkishel
force-pushed
the
PUP-8949_use_install_options_with_latest
branch
4 times, most recently
from
e41a3ee to
3ddbc72
Compare
add acceptance tests for pip
tkishel
force-pushed
the
PUP-8949_use_install_options_with_latest
branch
from
3ddbc72 to
5079efd
Compare
|
I think this is done. I’ll submit a separate PR for gem acceptance tests, and post my findings regarding path issues in beaker. |
|
jenkins please test this on debian8-64a,debian8-32a,debian9-64a,debian9-32a,fedora28-64a,fedora29-64a,osx1012-64a,osx1013-64a,osx1014-64a,redhat5-64a,centos6-64a,centos6-32a,redhat7-64a,redhat8-64a,redhatfips7-64a,sles11-64a,sles11-32a,sles12-64a,sles12-POWERa,sles15-64a,solaris10-64a,solaris114-64a,ubuntu1404-64a,ubuntu1404-32a,ubuntu1604-64a,ubuntu1604-32a,ubuntu1804-64a,windows2016-64a,windows2019-64a |
6 participants
Prior to this commit ...
The 'latest_with_new_pip' and 'latest_with_old_pip methods' (called by the
'latest' method) failed to execute
pip installwith the resource'sinstall_optionsattribute, potentially resulting in a lack of idempotency.With this commit ...
Any 'install_options' are applied whenever 'install' is executed.